Conversation
This removes the `LP` property of the `SolverConfiguration` since all information is stored in the `linsolver`. The initializer is now triggered much later in the `solve`-call: after system matrix and right hand side are known. This is important when restrictions are in use. Moreover, we do not need to assemble a `u` vector for the linear solver. This is done in the init-call.
pjaap
force-pushed
the
feature/rework-init
branch
from
c764a0a to
d0aebce
Compare
pjaap
changed the title
Member
Author
|
Seems to work fine after a few adjustments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
LPproperty of theSolverConfigurationsince all information isstored in the
linsolver.The initializer is now triggered much later in the
solve-call: after system matrixand right hand side are known. This is important when restrictions are in use.
Moreover, we do not need to assemble a
uvector for the linear solver. This is donein the init-call.